Create two separate workflows for circleci. #1082
Conversation
Workflow that deploys requires a git tag to run. Adding a tag filter would require all other tasks to have a tag as well. Splitting into two workflows, the build-test flow can work on all other branches/commits while build-test-deploy only works when a git tag matching vX.X.X is pushed.
|
Thanks sooo much for working on this! Question, does the regex for the tag version just mean we can only have single digits e.g. 2.2.0 but not 13.2.0? |
| only: master | ||
| ignore: /.*/ | ||
| tags: | ||
| only: /^v[0-9]+\.[0-9]+\.[0-9]+/ |
There was a problem hiding this comment.
Do we just want to have tags in the deploy job? Could you clarify why it's in the other jobs?
There was a problem hiding this comment.
According to CircleCI documentation on using tags if a job has a tag filter and relies on any other job, that one must have a tags filter as well. So since we want to use a filter tag in deploy, since it relies on upload-coverage which relies on build those jobs would require the filters tag as well. Or that's my interpretation on that at any rate.
|
Regex means it has to match vX.X.X but any of the X can contain any number of characters that match [0-9]. So v12.2.1 is supported, as is something like v1.2.10000 |
Description
Workflow that deploys requires a git tag to run. Adding a tag filter
would require all other tasks to have a tag as well. Splitting into two
workflows, the build-test flow can work on all branches/commits
while build-test-deploy only works when a git tag matching vX.X.X is pushed.
More Details
Git Tag Documentation
According to the documentation if using tag filters and a job requires any other job directly or indirectly, those jobs must also require regular expression filters for tags.
Corresponding Issue
#1075
Screenshots
Test Coverage
🚫