Rewrite Finder using React, Gatsby, and DS (WIP) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remind me to make small commits more often
lachlanjc
reviewed
Apr 5, 2018
src/pages/index.js
Outdated
| import qs from "query-string"; | ||
|
|
||
| class IndexPage extends Component { | ||
| constructor(props) { |
There was a problem hiding this comment.
Not a big deal, but the pattern of a static for initial state + automatic function binding is preferable:
https://github.com/withspectrum/spectrum/blob/alpha/src/components/chatInput/index.js#L76-L123
There was a problem hiding this comment.
the majority of this page component should be relocated to its own component/broken up a bit. most of this functionality should be render-able from any page on the site.
Fix scripts
lachlanjc
reviewed
Apr 15, 2018
src/components/ClubCard.js
Outdated
| @@ -131,7 +130,7 @@ class ClubCard extends Component { | |||
| <Photo src={`/school/${data.id}.jpg`} ready={ready} /> | |||
| </Box> | |||
| <Flex p={3} justify="space-around" flexDirection="column" style={{ flex: 1 }}> | |||
| <Heading.h4>{data.name}</Heading.h4> | |||
| <Heading.h4 style={{ textTransform: "capitalize" }}>{data.name}</Heading.h4> | |||
There was a problem hiding this comment.
I don't want it to be uppercased 😛
There was a problem hiding this comment.
oh! yes. every time I see textTransform I figure it's uppercase. sorry, will quietly duck out of the room now :)
I need to make smaller commits more often
Closed
Apply fix from hackclub/design-system#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.