Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen support #25

Closed
philn opened this issue Jun 6, 2018 · 9 comments
Closed

Fullscreen support #25

philn opened this issue Jun 6, 2018 · 9 comments
Labels
enhancement New feature or request

Comments

@philn
Copy link
Member

philn commented Jun 6, 2018

It would be nice to have a command-line option for this. And also one to be able to specify the default window size.

@aperezdc aperezdc added the enhancement New feature or request label Jun 13, 2018
@philn
Copy link
Member Author

philn commented Jun 26, 2018

There's an env var, already, I think that's a good start :)
Would be nice though to have runtime keyboard shortcuts so we can easily toggle between fullscreen states.

@philn
Copy link
Member Author

philn commented Jun 26, 2018

Default window size also has env vars, good for me!

@elima
Copy link
Contributor

elima commented Jun 26, 2018

@philn, F11 should toggle fullscreen. It is currently hardcoded in -fdo.

@philn
Copy link
Member Author

philn commented Jun 26, 2018

Sweet, so... what's left for this issue? Not much it seems :)

@aperezdc
Copy link
Member

Well, it would be better that the feature is not tied to the FDO platform only; which would need solving #22, I'd say.

@concreted
Copy link

I couldn't find any documentation for these env vars, the ones defined here seem to be the ones used for fullscreen: https://github.com/Igalia/cog/blob/6f1be78103323bc9e0964b73372e017b6c1b1cb5/platform/cog-platform-fdo.c

For example COG_PLATFORM_FDO_VIEW_FULLSCREEN=1 cog -P fdo https://threejs.org/examples/#webgl_terrain_dynamic worked for me, using weston with the default desktop shell.

Hope that helps anyone who is looking for how to run this fullscreen

@davidperrenoud
Copy link

Today's equivalent would be COG_PLATFORM_WL_VIEW_FULLSCREEN=1 cog -P wl https://threejs.org/examples/#webgl_terrain_dynamic

@manuelafm
Copy link
Contributor

Documentation for Wayland platform in: https://github.com/Igalia/cog/blob/master/docs/platform-wl.md

@aperezdc
Copy link
Member

I will close this tentatively, as we have ways for:

  • Setting default window size.
  • Setting fullscreen.
  • Toggling fullscreen with F11.

While not all plug-ins support those, we can use new issues to tackle that, like #22 mentioned earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants