Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that code formatting and style is consistent #70

Closed
aperezdc opened this issue Nov 28, 2018 · 3 comments
Closed

Ensure that code formatting and style is consistent #70

aperezdc opened this issue Nov 28, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aperezdc
Copy link
Member

Code style more or less follows that of GLib. It would be good to make sure that all the files are formatted accordingly. For example platform/cog-platform-fdo.c has many instances of missing spaces between function names and the opening parenthesis for the argument list.

@aperezdc aperezdc added enhancement New feature or request good first issue Good for newcomers labels Nov 28, 2018
@aperezdc
Copy link
Member Author

aperezdc commented Jan 7, 2019

It seems that there are no tools which would do GLib style 100% correctly, but for example the GNOME Web repository has a configuration file for Uncrustify which looks like a good starting point (thanks to @mcatanzaro for pointing it out).

@Cwiiis
Copy link
Contributor

Cwiiis commented Sep 13, 2021

We now have both CI code style checking and a pre-commit hook that checks style - given that a PR to correct all existing mistakes was rejected, is it safe to say that there's nothing left to do here?

@aperezdc
Copy link
Member Author

@Cwiiis: you are right, I also think we can close this 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants