Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last master fails to work with non-fdo #9

Closed
clopez opened this issue May 15, 2018 · 3 comments
Closed

Last master fails to work with non-fdo #9

clopez opened this issue May 15, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@clopez
Copy link
Contributor

clopez commented May 15, 2018

Not sure if this was caused by 17cfde0 or it was a previous issue.

I'm testing with ae3e565 and wpebackend-rdk/wayland-egl and cog is currently broken unless a "-P randomstring is passed".

Simply starting cog without parameters fails with:

root@qemux86-64:~# cog http://igalia.com
(cog:2550): Cog-DEBUG: platform_setup: Platform name: (null)
(cog:2550): Cog-DEBUG: platform_setup: Platform = (nil)

(cog:2550): Cog-CRITICAL **: cog_platform_get_view_backend: assertion 'platform != NULL' failed
**
Cog:ERROR:/usr/src/debug/cog/20180514-r0/git/cog.c:301:on_create_web_view: 'error' should not be NULL
Aborted

Starting it with a random invalid platform plugin name however works

root@qemux86-64:~# cog -P nonexistent http://igalia.com
(cog:2557): Cog-DEBUG: platform_setup: Platform name: nonexistent
(cog:2557): Cog-DEBUG: platform_setup: Platform plugin: libcogplatform-nonexistent.so

(cog:2557): Cog-WARNING **: Could not load: libcogplatform-nonexistent.so (possible cause: Socket operation on non-socket).

(cog:2557): Cog-DEBUG: Instantiating default WPE backend as fall-back.
xkbcommon: ERROR: couldn't find a Compose file for locale "C"
Cog-Message: <http://igalia.com/> Load started.
Cog-Message: <http://www.igalia.com/> Redirected.
Cog-Message: <https://www.igalia.com/> Redirected.
Cog-Message: <https://www.igalia.com/> Loading...
Cog-Message: <https://www.igalia.com/> Loaded successfully.
clopez added a commit to clopez/cog that referenced this issue May 15, 2018
…ia#9)

This fixes a bug where platform_name() was beeing returning TRUE when
no platform_name is defined. Causing it to assert on the calls to
on_create_web_view() -> cog_platform_get_view_backend()
@macpijan
Copy link

@clopez Just want to report similar issue when building from: Igalia/meta-webkit@83b5700
wpebackend-fdo was used in my case

cog  https://people.igalia.com/clopez/wkbug/fps-counter/raf_onload.html
(cog:528): Cog-CRITICAL **: cog_platform_get_view_backend: assertion 'platform != NULL' failed
**
Cog:ERROR:/usr/src/debug/cog/20180514-r0/git/cog.c:301:on_create_web_view: 'error' should not be NULL

In my case also libWPEBackend-default.so was missing, but that's another (or mine) issue:

cog -P fdo  https://people.igalia.com/clopez/wkbug/fps-counter/raf_onload.html
xkbcommon: ERROR: couldn't find a Compose file for locale "C"
wpe: could not load the impl library. Is there any backend installed?: libWPEBackend-default.so: cannot open shared object file: No such file or directory
Wayland: Got a wl_compositor interface
Wayland: Got a wl_seat interface
Wayland: Got an xdg_shell interface
Wayland: Got a wl_shell interface
EGL initialized with version 1.4

After adding a symlink to wpebackend-fdo:

xkbcommon: ERROR: couldn't find a Compose file for locale "C"
Cog-Message: <https://people.igalia.com/clopez/wkbug/fps-counter/raf_onload.html> Load started.
Cog-Message: <https://people.igalia.com/clopez/wkbug/fps-counter/raf_onload.html> Loading...
Cog-Message: <https://people.igalia.com/clopez/wkbug/fps-counter/raf_onload.html> Loaded successfully.
https://people.igalia.com/clopez/wkbug/fps-counter/raf_onload.html:38:14: CONSOLE LOG Measured 18.07802093244529 FPS in 1051 milliseconds.
https://people.igalia.com/clopez/wkbug/fps-counter/raf_onload.html:38:14: CONSOLE LOG Measured 19.083969465648856 FPS in 1048 milliseconds.
https://people.igalia.com/clopez/wkbug/fps-counter/raf_onload.html:38:14: CONSOLE LOG Measured 19.10219675262655 FPS in 1047 milliseconds.
https://people.igalia.com/clopez/wkbug/fps-counter/raf_onload.html:38:14: CONSOLE LOG Measured 18.98101898101898 FPS in 1001 milliseconds.
https://people.igalia.com/clopez/wkbug/fps-counter/raf_onload.html:38:14: CONSOLE LOG Measured 17.24137931034483 FPS in 1044 milliseconds.

@aperezdc aperezdc added the bug Something isn't working label May 15, 2018
@aperezdc
Copy link
Member

@macpijan: About the missing libWPEBackend-default.so symlink, I have experienced that myself. We are not yet at the point where loading a platform plug-in makes the symlink unnecessary, but ideally when using a Cog platform plug-in the symlink should not be needed... I have filed #11 to track that separately.

clopez added a commit that referenced this issue May 15, 2018
This fixes a bug where platform_name() was beeing returning TRUE when
no platform_name is defined. Causing it to assert on the calls to
on_create_web_view() -> cog_platform_get_view_backend()
@clopez
Copy link
Contributor Author

clopez commented May 15, 2018

This has been fixed in
4408909 for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants