💄 Style: update hero banner header #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/igihcksn1/mypocketmonsters/5wp3XGN8zcDuzJXDb7Gidr2Qpp54 |
igihcksn
reviewed
Oct 17, 2021
| <img src={PokemonIcon} alt="Pokemon Logo" /> | ||
| <PokeHeaderImg src={PikachuHead} alt="Pokemon Logo" /> | ||
| </PokeHeaderImgContainer> | ||
| <div class="poke-header"> |
There was a problem hiding this comment.
Hi @panchoroo When we have an header in component better use a semantic to get better performance, so i think its better to use
rather than
Closed
igihcksn
added
enhancement
Closed
|
Nice changes @panchoroo thank you, appreciate ur help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the hero banner header and removed some unused code. The styling is responsive so it works for all sizes of devices.
desktop:
mobile:
