Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20 by exposing the initial http.Request on the session #24

Merged
merged 1 commit into from
May 8, 2015

Conversation

mweibel
Copy link
Contributor

@mweibel mweibel commented May 7, 2015

Fixes #20

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 94.43% when pulling 64b59d7 on mweibel:feature/20-expose-http-request into 50b75e1 on igm:v2.

igm added a commit that referenced this pull request May 8, 2015
Fixes #20 by exposing the initial http.Request on the session
@igm igm merged commit 6571859 into igm:v2 May 8, 2015
@fatih
Copy link
Contributor

fatih commented May 18, 2015

Btw this broke our sockjs client which was using the session interface:

https://travis-ci.org/koding/kite/jobs/62776474

Here is the sockjsclient implementation: https://github.com/koding/kite/tree/master/sockjsclient

Because there is a new method, the clients are not compiling anymore because they do not satisfy the sockjs.Session interface anymore.

I thought the point of using gopkg.in was to avoid such things. This PR is definitely something that breaks the exposed interface. So it should be released under the version v3.

@igm
Copy link
Owner

igm commented May 18, 2015

I'm sorry @fatih , I'll revert this merge. I should have thought about this more carefully. Interface change is definitely an API change.

@igm
Copy link
Owner

igm commented May 18, 2015

Just to add, the revert happened in "v2" branch only, so that the change remains in "dev" version in "master" branch. In order to use "dev" make sure to import "github.com/igm/sockjs-go/sockjs".

@fatih
Copy link
Contributor

fatih commented May 18, 2015

Thanks @igm for the change.

@mweibel
Copy link
Contributor Author

mweibel commented May 18, 2015

sorry @fatih @igm - not yet fully used to the golang way ;) -- @igm is there anything I'd need to do still or all ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants