Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with rebinning #1063

Closed
iprafols opened this issue May 7, 2024 · 1 comment
Closed

Possible issue with rebinning #1063

iprafols opened this issue May 7, 2024 · 1 comment
Assignees

Comments

@iprafols
Copy link
Collaborator

iprafols commented May 7, 2024

@andreicuceu noted that there is potentially an issue with the way we are doing the rebinning.

Original message by Andrei:
I think there's a small bug in picca delta extraction when defining the wavelength grid. These are true continuum deltas for the same forest, run with both picca and qsonic. You can see that for mocks the grid is slightly shifted compared to the data, so the bin centers are at 3599.9, 3600.7, etc. instead of 3600.0, 3600.8, etc.. QSOnic has the correct grid, while picca shifts everything by 0.1A to the data grid. This is not a big deal, but it would be good to fix both the bug in picca and the shifted grid in QQ.

issue

@iprafols iprafols self-assigned this May 7, 2024
@iprafols
Copy link
Collaborator Author

iprafols commented May 15, 2024

This is not a PICCA issue, that PICCA behaves as expected, but rather a quick quasars issue. While we wait for QuickQuasars to be fixed, it suffices to specify lambda min = 3599.9 and lambda max = 5499.9 in the [data] section in the delta extraction config
issue_check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant