Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding merge-groups to actions #1014

Merged
merged 5 commits into from
Jun 16, 2023
Merged

adding merge-groups to actions #1014

merged 5 commits into from
Jun 16, 2023

Conversation

Waelthus
Copy link
Contributor

No description provided.

@Waelthus Waelthus marked this pull request as ready for review June 15, 2023 16:26
@Waelthus Waelthus requested a review from iprafols June 15, 2023 16:26
@Waelthus
Copy link
Contributor Author

I activated merge queues with a queue length of 1, so we can run the github action for version bumping on that which would then merge to the non-protected merge-queue-branch before merging into master. This should always add a version per PR, as PRs are merged after each other...
All tests will be run once more on the merge event and merging will only happen if they succeed...
We could try longer queues, not sure what would happen in that case.

remove automatic tagging, I guess the tagged version would be pre merge elsewise...
@Waelthus Waelthus enabled auto-merge June 15, 2023 16:37
@Waelthus Waelthus disabled auto-merge June 15, 2023 16:39
@Waelthus Waelthus enabled auto-merge June 15, 2023 16:39
@Waelthus
Copy link
Contributor Author

should close #1010

Copy link
Collaborator

@iprafols iprafols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@Waelthus Waelthus added this pull request to the merge queue Jun 16, 2023
Merged via the queue into master with commit e6f3fc8 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants