Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default redshift evolution to match QSO #974

Merged
merged 4 commits into from
Feb 17, 2023

Conversation

andreicuceu
Copy link
Contributor

@andreicuceu andreicuceu commented Feb 7, 2023

When computing the cross-correlation (and xdmat, metal_xdmat, xwick, etc.) the redshift evolution parameter for discrete objects was set to 1. This PR changes it to 1.44 to match the value used for quasars in DR16. This is in line with what we do for the delta field where the default is 2.9 (value of alpha_lya).

Copy link
Collaborator

@iprafols iprafols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look fine but we should set up the test to keep using the old value or else update the test results so that we can pass the tests

@iprafols iprafols merged commit e958d9e into master Feb 17, 2023
@iprafols iprafols deleted the update_default_qso_z_evol branch February 17, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants