Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server to maintain and sync client_id -> chat_user_id mapping, world sync to send chat_user_id to client #38

Merged
merged 7 commits into from
Feb 16, 2023
Merged

server to maintain and sync client_id -> chat_user_id mapping, world sync to send chat_user_id to client #38

merged 7 commits into from
Feb 16, 2023

Conversation

f8122dac91
Copy link
Member

related #34

@vercel
Copy link

vercel bot commented Feb 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
telegram-space ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 11:38AM (UTC)

@f8122dac91 f8122dac91 changed the title [WIP] server to maintain and sync client_id -> chat_id mapping [WIP] server to maintain and sync client_id -> chat_user_id mapping Feb 15, 2023
@f8122dac91
[server] add PlayerChatUserIdAcknowledge
00a9de8 
 - the message will be used to sync `PlayerInstance` message
   - on sending `PlayerChatUserId` message, client awaits the acknowledge
   - on client receiving the acknowledge, it proceeds to register to an instance by sending `PlayerInstance` message
   - now server can be sure that the player entering to an instance has its chat_user_id registered already
 - minor-edit: SenderService::try_send helper assoc func
@f8122dac91 f8122dac91 mentioned this pull request Feb 15, 2023
Merged
@f8122dac91
[client, server] (TEMPORARY) implement chat_user_id sync
24cdde9 
 - this solution is temporary
 - chat_user_id is sent to clients in an instance alongside with the
   world state data
 - the payload is encoded inside a (godot) `Array` of `PackedBytesArray`
   - Array[
      world_state_data: PackedByteArray[
        Array[
          PackedByteArray[
            WorldStateEntry
          ]
        ]
      ],
      client_chat_user_ids: PackedByteArray[
        Array[
          PackedByteArray[ClientId + utf8_string]
        ]
      ]
     ]
@f8122dac91 f8122dac91 changed the title [WIP] server to maintain and sync client_id -> chat_user_id mapping server to maintain and sync client_id -> chat_user_id mapping, worldsync to send chat_user_id to client Feb 16, 2023
@f8122dac91 f8122dac91 changed the title server to maintain and sync client_id -> chat_user_id mapping, worldsync to send chat_user_id to client server to maintain and sync client_id -> chat_user_id mapping, world sync to send chat_user_id to client Feb 16, 2023
@f8122dac91
Copy link
Member Author

24cdde9 implements a temporary solution for syncing chat_user_id:

  • chat_user_id is sent to clients in an instance alongside with the world state data
  • the payload is encoded inside a (godot) Array of two PackedBytesArray:
   Array[
      world_state_data: PackedByteArray[
        Array[
          PackedByteArray[
            WorldStateEntry
          ]
        ]
      ],
      client_chat_user_ids: PackedByteArray[
        Array[
          PackedByteArray[ClientId + utf8_string]
        ]
      ]
     ]

@f8122dac91 f8122dac91 mentioned this pull request Feb 16, 2023
Open
@f8122dac91 f8122dac91 merged commit dd3b447 into master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@f8122dac91