Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added a note to distinguish between chain accounts and Ignite accounts #2777

Merged
merged 4 commits into from
Sep 2, 2022

Conversation

fadeev
Copy link
Contributor

@fadeev fadeev commented Aug 24, 2022

No description provided.

Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a changelog entry !

@tbruyelle
Copy link
Contributor

Just need a changelog entry !

or a Skip-Changelog label, not sure if we want to add CL entries for documenation?

@tbruyelle
Copy link
Contributor

tbruyelle commented Aug 24, 2022

@fadeev I realize that this distinction between ignite account and appd keys is maybe not so deep, since we recently added the --keyring-dir flag in #2669.

For instance, giving the following blogd keys :

$ blogd keys list
- name: alice
  type: local
  address: cosmos1wzuums2e3t3jkz7ym4thjecype5352zds9h96d
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AjAuPBMEhuB/BVcJbYvnbsfh3GrQswod3OsiIOWyO/TC"}'
  mnemonic: ""
- name: bob
  type: local
  address: cosmos1l6twp8lkzskpch4wdej5gsee7tuhk9agypjxxa
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"A/piEG8Yivahuib/AG8XOMUQB4r+YhfbaH8qJk/O9pT8"}'
  mnemonic: ""

I can query them with ignite account too :

$ ignite account list --keyring-dir ~/.blog/
Successfully migrated key alice.info.
Successfully migrated key bob.info.
Name 	Address 					Public Key 							
alice 	cosmos1wzuums2e3t3jkz7ym4thjecype5352zds9h96d 	PubKeySecp256k1{02302E3C130486E07F0557096D8BE76EC7E1DC6AD0B30A1DDCEB2220E5B23BF4C2} 	
bob 	cosmos1l6twp8lkzskpch4wdej5gsee7tuhk9agypjxxa 	PubKeySecp256k1{03FA62106F188AF6A1BA26FF006F1738C510078AFE6217DB687F2A264FCEF694FC} 	

And now I've just reproduced the problem a user has in #2773 !!! If I run blogd keys list after that, I got Error: Bytes left over in UnmarshalBinaryLengthPrefixed, should read 10 more bytes but have 152 😨

It seems like ignite account migrates the account from amino encoding to protobuf, but then blogd keys is no longer able to read them, that's annoying...

This is related to a migration of the keyring added in v0.46 (cosmos/cosmos-sdk#9695)

@fadeev
Copy link
Contributor Author

fadeev commented Aug 25, 2022

@tbruyelle good to know! 👍 It still might be a good practice to use the chain's binary for key management, but I will expand the description of this command in the following PRs.

@fadeev fadeev added the skip-changelog Don't check changelog for new entries label Aug 29, 2022
@aljo242 aljo242 merged commit d0fd60f into develop Sep 2, 2022
@aljo242 aljo242 deleted the docs/account-cmd branch September 2, 2022 15:13
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
…ccounts (ignite#2777)

* docs: added a note to distinguish between chain accounts and Ignite accounts

* fix: typo

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Don't check changelog for new entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants