fix(template): added no-legacy-stdTx flag #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marinhoarthur does this PR fixes #128? |
|
@fadeev yes |
fadeev
changed the title
fadeev
changed the title
Matthews3301
approved these changes
Nov 22, 2021
mihailmarcu
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Hey @marinhoarthur,
After our session where we reproduced the issue and tested the final fix I can tell that your solution fixed this error.
You can easily go and merge the changes.
Checklist when testing a PR
- Code review
- The bug was reproduced locally
- Manual testing performed
- Changes made fixed the bug
- No potential merge conflicts with develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Legacy endpoint /txs with stargate v0.44 keplr transaction fails with basic send-token
Signing transactions with Keplr error