Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OF-2830 plugin servlet mapping #2463

Merged
merged 2 commits into from
Aug 22, 2024
Merged

OF-2830 plugin servlet mapping #2463

merged 2 commits into from
Aug 22, 2024

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Jun 10, 2024

Two commits:

  • the first adds unit tests, which necessitates a bit of refactoring of the code under test.
  • the second commit intends to fix the issue.

@guusdk guusdk requested a review from Fishbowler June 10, 2024 14:24
@guusdk
OF-2830: PluginServlet refactoring + unit tests
c169651 
This adds unit tests that assert the problems identified in OF-2830. To facilitate unit tests, some refactoring of the code under test was needed. This does not intend to introduce functional changes.
@guusdk
OF-2830: Fix wildcard mapping for plugin servlets
95d40f6 
This replaces the pre-existing matching implementation of URLs (that may contain wildcards) with one that is more robust (and passes the unit tests introduced by the previous commit).
@guusdk guusdk force-pushed the OF-2830_PluginServlet-mapping branch from 40fd59d to 95d40f6 Compare July 16, 2024 17:39
@akrherz akrherz merged commit ab537c1 into igniterealtime:main Aug 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrherz akrherz akrherz approved these changes

@Fishbowler Fishbowler Awaiting requested review from Fishbowler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guusdk @akrherz