Store node reference in visitor's cache. #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review checklist
CHANGELOG.md
, no needto update for typo fixes and such).
Hi, @igordejanovic ,
I've made the fix according to our today's discussion.
It may not be guaranteed that the
node
is always preserved during the wholevisitor
execution (e.g. if thenode
is not the AST node, but the tuple containing it). This is the rationale for keeping the reference to thenode
object incache
.Best,
Vladimir