-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extraDependencies
for createQuery
and createJsonQuery
#372
extraDependencies
for createQuery
and createJsonQuery
#372
Conversation
This reverts commit 251f3a0.
extraDependecies
for createQuery
and createJsonQuery
extraDependencies
for createQuery
and createJsonQuery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution 😇
- I am not sure if this change is good. Let's finish discussion in the issue first.
- We do not accept any features without docs and changesets. Please, refer to the contributions guide in the readme.
7e4ef8a
to
69132c3
Compare
There is no way to provide custom |
Check internal implementation of createQuery. You can write something like this in your code. |
Sure I also can fork whole farfetched to my codebase if i need 1 simple extra parameter. But i dont want all of that complexity and extra maintaining cost for new releases, so i decided to contribute to main repo If u think its wrong fit just say it and close PR/issue. I will start looking to find a way to deal with my cases in my codebase instead |
Sorry, without strong motivation and any documentation I simply do not get why this feature has to be in core. Please, provide proper RFC and documentation and reopen PR with it 🙏 |
fixes: #350