fix: Align the body of graph.lattice() with its replacement make_lattice()

[maelle]

This is the fix for BCT, at least it fixes the reprex 😁

I'm a bit worried about these functions we inlined, looking forward to deprecating the old versions for good so we don't have to backport all changes. 😰

s <- c("2", "11", "00", "10", "12", "011", "020", "021", "012", "022", 
"0100", "0102", "0101") 
init_g <- igraph::make_empty_graph(n=1)
igraph::V(init_g)$name <-""
g <- init_g
for (word in c(s)) {
   print(word)
    # turns "10100" into c("1","10","101","1010", 10100")
    subwords <- stringr::str_sub(word, 1, 1:nchar(word))
    # make a graph long enough to hold all those sub-words + start node
    subg <- igraph::graph.lattice(length(subwords)+1,directed=TRUE)
    # set vertex nodes to start node plus sub-words
    igraph::V(subg)$name <- c("",subwords)
    # merge *by name* into the existing graph
    g <- igraph::union(g, subg)
 }
#> [1] "2"
#> Warning: `graph.lattice()` was deprecated in igraph 2.0.4.
#> ℹ Please use `make_lattice()` instead.
#> This warning is displayed once every 8 hours.
#> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was
#> generated.
#> [1] "11"
#> [1] "00"
#> [1] "10"
#> [1] "12"
#> [1] "011"
#> [1] "020"
#> [1] "021"
#> [1] "012"
#> [1] "022"
#> [1] "0100"
#> [1] "0102"
#> [1] "0101"

^{Created on 2024-07-19 with reprex v2.1.0}

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[krlmlr]

Good catch, thanks!

[krlmlr]

Perhaps:

Suggested change

	res$circular <- periodic
	res$periodic <- periodic
	res$circular <- periodic

[maelle]

we don't have this in the original body copied here.