Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Leiden algorithm #399

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Added the Leiden algorithm #399

merged 2 commits into from
Oct 23, 2020

Conversation

vtraag
Copy link
Member

@vtraag vtraag commented Jun 26, 2020

I've added the Leiden algorithm to the R interface. I've also added a simple test.

The functions.def did not yet include igraph_community_leiden in the igraph C core. For that reason the cigraph submodule points to this commit in the fix/leiden-R branch for now. If all is well here on the R side as well, we can merge fix/leiden-R to the master branch, and update the cigraph submodule to the master branch.

@vtraag
Copy link
Member Author

vtraag commented Jun 27, 2020

I just realised I forgot to update the documentation, it was just copy-pasted from Python interface.

@vtraag
Copy link
Member Author

vtraag commented Jun 28, 2020

This PR closes #346 by the way.

@ntamas
Copy link
Member

ntamas commented Jul 1, 2020

Merged igraph/igraph#1422 now; I leave it up to someone familiar with the R internals to merge / close this one.

@timoast
Copy link

timoast commented Sep 25, 2020

Hi, just wondering if there is any rough timeline for this being merged? We're very interested in using this functionality in the Seurat R package once it's available. I'd be happy to help if there's anything I can do to move this along

@vtraag
Copy link
Member Author

vtraag commented Sep 26, 2020

We should ask @gaborcsardi. As far as I am concerned this is good to go.

@TomKellyGenetics
Copy link

@timoast I will update the leiden R package to call this (as it should improve performance) when it becomes available. Of course, you are also welcome to change Seurat, let me know if you want help with it.

@gaborcsardi gaborcsardi merged commit d5d7ca5 into igraph:dev Oct 23, 2020
@gaborcsardi
Copy link
Contributor

Thanks!

@vtraag vtraag deleted the feature/leiden branch October 27, 2020 12:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants