Adding recursive xorpad file search and crc32 support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Many xorpad repos/distributions now include the CRC32 of the title in the filename. In many cases the xorpad files are also split into multiple subfolders. Currently, 3dsconv will not discover xorpad files in subdirectories or with crc32 info in their filename. In some cases, titles may have multiple revisions. By calculating the crc32 of the input file we can more accurately find its related xorpad. Changes: - The xorpad directory is now searched recursively for xorpad files - xorpad files are searched in a case-insensitive fashion - Discover and prefer xorpad files with matching crc32 in the filename Extra info: I wrote the CRC32 function included here for minimal memory use and high speed. zlib is about 5x faster than using binascii.crc32.
|
Need to make a change to this. My break in the file loop is not adequate. Will fix momentarily |
Summary: Whoops, python doesn't let you break out of nested loops like that. Moved xorpad search to a function. Also added useful display output during crc32 calculation, and displaying each title to help demarcate individual conversions.
|
OK, changes applied and tested. |
|
I'm going to collapse these commits together and add another fix, so closing this. |
|
"collapse" you mean squash? github already allows doing that at merge-time, so doing it manually is not required anymore. |
|
Oh nice, I didn't realize. Was gonna do an --amend on my side. I'll commit one more thing real quick to fix the bug I just came across |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Many xorpad repos/distributions now include the CRC32 of the title in the filename. In many cases the xorpad files are also split into multiple subfolders. Currently, 3dsconv will not discover xorpad files in subdirectories or with crc32 info in their filename. In some cases, titles may have multiple revisions. By calculating the crc32 of the input file we can more accurately find its related xorpad.
Changes:
Extra info:
I wrote the CRC32 function included here for minimal memory use and high speed. zlib is about 5x faster than using binascii.crc32.