Support basic mdf writing of .NET #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finish basic uses
ihedvall
requested changes
Jul 23, 2023
There was a problem hiding this comment.
MdfFactory.h/cpp
This change of C++ signature may cause problemfor existing c++ users. I suspect that it's the unique_ptr (memory) include that causing the problem. Maybe moving the include MdfFactory.h from the mdfwrite.h to its cpp file will fix the problem.
|
ok, I will create a new function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I change the return type of
CreateMdfWriter&CreateMdfFileininclude/mdf/mdffactory.hto common ptr to avoid unnecessary type casting. I don't think it's a good choice to return unique_ptr in an interface, it should be down by the users themselves.I just finish writing the basic features, if any futher supports needed, please tell me.