Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kingdom Overview screen, Heroes Overview and Towns/Castles Overview screens, left click on hero's portrait and on castle sprite #1847

Closed
LeHerosInconnu opened this issue Sep 30, 2020 · 1 comment · Fixed by #2299
Assignees
Labels
good first issue Good for newcomers improvement New feature, request or improvement ui UI/GUI related stuff
Milestone

Comments

@LeHerosInconnu
Copy link

In the original game, when the player left click on a hero's portrait, the hero screen is displayed.
And when the player exits the hero screen, he end up in the adventure map screen.

In fheroes2, it would be nice if the player could left click on a hero's portrait to display the hero screen.
An improvement can be made to the original game by having that when the player exits the hero screen, he returns to where he was on the Kingdom Overview screen and not on the adventure map screen.

In the original game, when the player left click on a castle sprite, the castle screen is displayed.
And when the player exits the castle screen, he end up in the adventure map screen.

In fheroes2, it would be nice if the player could left click on a castle sprite to display the castle screen.
The same improvement can be made to the original game by having that when the player exits the castle screen, he returns to where he was in the Kingdom Overview screen and not on the adventure map screen.

In fheroes2 it would also be nice to make sure that when the player left click on the captain portrait/empty captain slot (so when there is no hero portrait in that slot), the castle screen is also displayed.

In original game:

Kingdom Heroes H2 01

Kingdom Towns H2 01

@ihhub ihhub added improvement New feature, request or improvement good first issue Good for newcomers Hacktoberfest ui UI/GUI related stuff labels Sep 30, 2020
@ihhub ihhub added this to the 0.9 milestone Sep 30, 2020
@ihhub
Copy link
Owner

ihhub commented Sep 30, 2020

The start point would be to check OpenDialog method of hero and castle classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants