Castle screen, fully built castle, differences noticed

[LeHerosInconnu]

In fheroes2, there are defects due to the display priority of sprites or/and sprites which are displayed differently.
In fheroes2, some defects have already been corrected compared to the original version of the game, they have not been reported here.

Sorceress' Castle.

• Pixels at the bottom and to the left of the Captain's Quarters do not have the same color as in the original game.

In original game:

In fheroes2:

Open the two images in different tabs in your browser, enlarge the images and switch between the two tabs alternately.
Heroes 2 first, fheroes2 second.

Edit 2020/12/21.

Knight's Castle.

To comply with the creature buildings color code, red for unimproved buildings and blue for upgraded buildings.
Knight castle, inverted the sprites for the Archery Range and the Upg. Archery Range (red and blue).

TWNKDW_1.ICN
0000.bmp

• replaced by 0000.bmp from TWNKUP_1.ICN

TWNKUP_1.ICN
0000.bmp

• replaced by 0000.bmp from TWNKDW_1.ICN

CSTLKNGT.ICN
0020.bmp

• renamed to 0025.bmp

0025.bmp

• renamed to 0020.bmp

Necromancer's Castle.

There is a problem with the Laboratory road connection.

In fheroes2:

In original game, corrected:

There is a problem with the Mage Guild road connection.

In fheroes2:

In original game:

Necromancer castle screen, changes needed to avoid display "flaws" when switching between castles with Mausoleum and upgraded Mausoleum.
The position of the sprites must be adjusted.
Note: Graphic modifications have also been applied, they will be specified in another issue (changes to the half top of the sprite).

TWNNDW_4.ICN
0000.bmp

TWNNUP_4.ICN
0000.bmp

In fheroes2:

In fheroes2:

In original game, corrected:

Open the three images in different tabs in your browser, enlarge the images and switch between the three tabs alternately.
fheroes2 unimproved dwelling first, fheroes2 upgraded dwelling second, Heroes 2 corrected position third.

All changes applied (graphics change included).
Heroes 2 original first, Heroes 2 corrected second.

[ihhub]

Hi @LeHerosInconnu , I've updated the order of building drawing. I didn't close this issue. Please check it again (once the compilation is done) and let me know if something is missing or simply close the issue if everything is fine. What I fixed:

• Tavern drawing in Barbarian castle
• Captain drawing in Necromancer castle
• Statue drawing in Knight castle
• Library drawing in Wizard castle

Of course not everything could be fixed as I noticed that the original game has even more issues than our.

[LeHerosInconnu]

@ihhub.

Hi @LeHerosInconnu , I've updated the order of building drawing. I didn't close this issue. Please check it again (once the compilation is done) and let me know if something is missing or simply close the issue if everything is fine. What I fixed:

• Tavern drawing in Barbarian castle
• Captain drawing in Necromancer castle
• Statue drawing in Knight castle
• Library drawing in Wizard castle

Of course not everything could be fixed as I noticed that the original game has even more issues than our.

All the changes you have made are working properly.
For other problems, it will certainly be necessary to slightly modify the graphics because a change in display priority will not necessarily solve the problem.

I suggest leaving the issue open as a reminder for the other problems.
If it's ok, I'll edit the first post to leave only the problems unfixed.

[ihhub]

Yes, please edit the first message. Maybe these pixel related issues because of another incorrect ICN decoding.

[LeHerosInconnu]

@ihhub.

Yes, please edit the first message. Maybe these pixel related issues because of another incorrect ICN decoding.

I edited the first post.

[ihhub]

@ihhub.

Yes, please edit the first message. Maybe these pixel related issues because of another incorrect ICN decoding.

I edited the first post.

Mmm.. I don't see any changes :(

[LeHerosInconnu]

@ihhub.

@ihhub.

Yes, please edit the first message. Maybe these pixel related issues because of another incorrect ICN decoding.

I edited the first post.

Mmm.. I don't see any changes :(

Maybe I hadn't updated the change. :)
It should be fine now.

[ihhub]

@LeHerosInconnu well, it happens. No worries :)

[ihhub]

Hi @LeHerosInconnu could you please verify castle drawings with latest commit? I made fixes for Barbarian castle roads.

Regarding different pixels in Knight and Sorceress castles: it might be that we miss some extra logic about image transcoding. I made some changes for images but it looks like it's not the case. So I don't know what's wrong with them.

[LeHerosInconnu]

Hello @ihhub,

Hi @LeHerosInconnu could you please verify castle drawings with latest commit? I made fixes for Barbarian castle roads.

Regarding different pixels in Knight and Sorceress castles: it might be that we miss some extra logic about image transcoding. I made some changes for images but it looks like it's not the case. So I don't know what's wrong with them.

Your corrections for the routes of the barbarian castle are working correctly.
It's perfect. :)
Did you modify the sprites "in the program", by cutting part of the sprites for example?

In these castles screens, there are also other flaws that have not been corrected in fheroes2, do you want me to report them in this thread, or it can wait?

I've modified the first post accordingly.

[ihhub]

Hi @LeHerosInconnu , I didn't modify any sprites but made a correct order of drawings.

If you spot some issues with sprites like incorrect pixels or colors, for example Calavry sprite which we fixed yesterday, please create a thread for this. We might able to fix it within an application without using modified assets of the game.

[LeHerosInconnu]

@ihhub.

Hi @LeHerosInconnu , I didn't modify any sprites but made a correct order of drawings.

If you spot some issues with sprites like incorrect pixels or colors, for example Calavry sprite which we fixed yesterday, please create a thread for this. We might able to fix it within an application without using modified assets of the game.

Okay, I will add the other defects of the castles in this thread and create another thread for the other defects.

[LeHerosInconnu]

First post updated with other flaws for Knight's Castle and Necromancer's Castle.

[ihhub]

Hi @LeHerosInconnu , could you please update the first post in regards to Knight castle since we fixed the issue with the Farm?

[LeHerosInconnu]

Hello @ihhub,

Hi @LeHerosInconnu , could you please update the first post in regards to Knight castle since we fixed the issue with the Farm?

First post updated.

[Eldorias-Piano-Covers]

Here is an animated gif concerning the Mosoleum pixel offset I was about to post (v 0.9.14) :

[ihhub]

Reclassifying this issue as asset enhancement with target for beyond 1.0.