Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High scores screen, the default name can be too long to fit the list #8778

Closed
2 tasks done
Branikolog opened this issue May 31, 2024 · 4 comments · Fixed by #9243
Closed
2 tasks done

High scores screen, the default name can be too long to fit the list #8778

Branikolog opened this issue May 31, 2024 · 4 comments · Fixed by #9243
Assignees
Labels
good first issue Good for newcomers improvement New feature, request or improvement low priority Low priority item which could be addressed in the future translation Things related to languages and translations ui UI/GUI related stuff
Milestone

Comments

@Branikolog
Copy link
Collaborator

Preliminary checks

Platform

Windows

Describe the bug

image

Save file

None.

Additional info

No response

@Branikolog Branikolog added improvement New feature, request or improvement ui UI/GUI related stuff translation Things related to languages and translations labels May 31, 2024
@Branikolog Branikolog added this to the 1.2.0 milestone May 31, 2024
@LeHerosInconnu
Copy link

Hello @Branikolog,

Hey, I made some nice scores. :D

@Branikolog
Copy link
Collaborator Author

Branikolog commented May 31, 2024

Hi, @LeHerosInconnu !
I was always wondering, how did you manage to make them on my own PC. :)

@LeHerosInconnu
Copy link

LeHerosInconnu commented May 31, 2024

@Branikolog,

Hi, @LeHerosInconnu ! I was always wondering, how did you manage to make them on my own PC. :)

Ah, Ah, Ah,

In fact, the name "Unknown Hero" comes from the game Heroes of Might and Magic 2.
The first time I validated the window that lets you enter a name for the high score, I hit the "enter" key without typing a letter in the text field, just to see.
It worked without a letter, and the name "Unknown Hero" was then displayed in the high score list.
I thought it was funny, and I used it afterwards for everything to do with the Heroes of Might and Magic serie, not forgetting the French version "Le Héros Inconnu".
Now, every time I see that name in a screenshot I didn't take myself, it makes me smile. :)

@fheroes2bugs
Copy link

If we want to improve "high scores screen" - I already have written an issue about it - #7795, may be we can add something from my issue too.

@ihhub ihhub added good first issue Good for newcomers low priority Low priority item which could be addressed in the future labels Jun 1, 2024
@ihhub ihhub self-assigned this Oct 27, 2024
ihhub added a commit that referenced this issue Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement New feature, request or improvement low priority Low priority item which could be addressed in the future translation Things related to languages and translations ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants