Fix the random generator usage by the non-Arena code #7967
Conversation
oleg-derevenetz
added
bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…he effect of spells
|
Regarding #7964: I believe that in this PR I have eliminated the main reasons for the discrepancies that led to a different outcome of the battle when performing the same actions by the AI and the human player. According to my tests, now the outcome of the battle should be the same if the AI and the human player perform exactly the same actions (by "exactly" I mean maximum accuracy - for example, if you cast a spell on a wide unit, that spell must be cast on exactly the same cell of that unit). I also checked the pseudo-random number chains during the AI-controlled battle and human-controlled battle (by performing the same actions) and I didn't see any differences with this PR. I hope that I have fixed all the causes of the former discrepancies. Regarding #7965: according to my tests with this PR, the battle outcome is the same when performing absolutely the same actions in Debug and Release builds, if both Release and Debug builds were created from the same source code using the same compiler. Just in case, let me remind once again that the same battle outcome in case of using different compilers is not currently guaranteed. And of course, this is not guaranteed in case of using different versions of the game (built from different versions of the source code), because changes are regularly made to the logic of the combat AI. |
There was a problem hiding this comment.
Hi @oleg-derevenetz , I left a set of comments and questions. Could you please take a look at them once you have free time?
|
@oleg-derevenetz , thank you so much for these useful changes! |
fix #7964
This PR prohibits the use of the
Battle::Arena's random generator by external code (mostly by AI decision-making code), which was the main reason for the non-reproducibility by a human of results of battles performed by AI.It also redesignes the
Battle::Commandsin order to be able to perform additional checks at compile time and introduces a few minor improvements.