Add text width-adapted CANCEL button, change to StandardWindow for Resolution, Language, Adventure, File and Scenario Info dialogs #8154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throws exception often when going from 1080p to 480p for some reason...
zenseii
added
improvement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
zenseii
changed the title
zenseii
changed the title
zenseii
changed the title
zenseii
changed the title
Districh-ru
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Hi, @zenseii, I did a quick overview of PR and left some comments. Could you please check them when you have time.
I'll do a more thorough review tomorrow.
Add EVIL ICN metallic box. Add disabled button draw call. Remove unnecessary redraws of dialog area outside of event loops.
Districh-ru
requested changes
Jan 4, 2024
There was a problem hiding this comment.
Hi, @zenseii, I left several comment. Could you please take a look when you have time?
|
@zenseii, could you please resolve the merge conflicts. |
Districh-ru
approved these changes
Jan 4, 2024
ihhub
approved these changes
Jan 5, 2024
|
@zenseii , huge thanks for these essential updates! |
Kazhuu
pushed a commit
to Kazhuu/fheroes2
that referenced
this pull request
Jan 31, 2024
…solution, Language, Adventure, File and Scenario Info dialogs (ihhub#8154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the single-lined CANCEL button adapt its width according to the text on it.
To make this possible it was necessary to switch to the StandardWindow class for the Language, Resolution, Adventure, File and Scenario Info dialogs. This also gives an evil interface mode for the first two mentioned dialogs plus the Scenario Info dialog.
The Uniform CANCEL button was adapted too and the Player name input dialog's keyboard button had to be moved to allow for that extra button width, since we don't have a way of widening that dialog yet.
The Scenario Info dialog's height was increased by a few pixels to avoid the overlapping of the handicap icons' shadow with the Okay and Cancel buttons.