Improved Versioning and Error Handling #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for tracking the version number and automatically pulling into setup.py and the __init__ file. Also improved the error message if None is passed into `compare_packages`. Added tox support for python 2.6, 2.7, 3.4, and 3.5. * pep compliance * version number * added rpm module to __init__ import * Added TypeError check when parsing versions to give useful output if someone accidentally passes a None * added setup.cfg with universal flag * fixed setup.cfg * Added tox support * Updated imports in test_common * Added version.py * Import __version__ and __version_info__ at package level * setup.py uses version.py to get version * Updated package level documentation in __init__.py * Moved stuff around a bit in __init__.py
| # The full version, including alpha/beta/rc tags. | ||
| release = '0.1.0' | ||
| release = '0.2.0' |
There was a problem hiding this comment.
These version numbers don't match the number in version.py (0.2.0 ≠ 0.2.2)
There was a problem hiding this comment.
Oh yeah. I always forget about Sphinx versioning. I'll try to get that to pull automatically, too.
|
Looks good to me, aside from a possible version number issue |
|
Check it out. Seems to work (you can check locally by running |
|
Cool, I approve! |
mplanchard
added a commit
that referenced
this pull request
Jan 13, 2016
Improved Versioning and Error Handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains some useful additions, including a
version.pyfor tracking the version number and automatically pulling into
setup.pyand the__init__file. Also improved the error messageif None is passed into
compare_packages. Added tox support forpython 2.6, 2.7, 3.4, and 3.5.
__init__importoutput if someone accidentally passes a None
setup.cfgwith universal flagsetup.cfgversion.py__version__and__version_info__at package levelsetup.pyusesversion.pyto get version__init__.py__init__.py