Develop #148
Merged
Develop #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- *Category*: bugfix - *JIRA issue*: [MIC-3070](https://jira.ihme.washington.edu/browse/MIC-3070) Existing code was expecting a different column name for both input_draw and random seed. This change corrects this. Testing Removed a seed's results from an existing results hdf file and attempted to `psimulate restart`, succeeded.
…146) - *Category*: bugfix - *JIRA issue*: [MIC-3193](https://jira.ihme.washington.edu/browse/MIC-3193) Changes - Uses `np.random.shuffle` rather than `np.random.choice` to choose the requested amount of draws and seeds - Note that this sets the max seed count to 10000. This is presumably reasonable. Testing Ran `psimulate run` and `psimulate expand` with breakpoints to watch draws and seeds be drawn deterministically.
…eowners add CODEOWNERS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v1.3.4
Description
Release v1.3.4
Testing
Automatic tests passed