add -h --hardware option #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
requested review from
albrja,
collijk,
hussain-jafari,
mattkappel,
patricktnast and
rmudambi
as code owners
stevebachmeier
commented
Jan 4, 2024
| import click | ||
|
|
||
| _RUNTIME_FORMAT = "hh:mm:ss" | ||
|
|
||
| # https://docs.cluster.ihme.washington.edu/#hpc-execution-host-hardware-specifications |
There was a problem hiding this comment.
Not sure of the best way to deal with the fact that the hardware changes. Alternatively we can not provide any constraints on what is passed in and leave it up to the user to "do their research"
| hardware = value.split(",") if value else [] | ||
| bad_requests = set(hardware) - set(_AVAILABLE_HARDWARE) | ||
| if bad_requests: | ||
| raise click.BadParameter( |
There was a problem hiding this comment.
Related to your above GitHub comment, do you think it would be useful to provide the URL in the code comment in the error message? (I see that's in the help already)
hussain-jafari
approved these changes
Jan 4, 2024
rmudambi
approved these changes
Jan 4, 2024
rmudambi
approved these changes
Jan 5, 2024
stevebachmeier
deleted the
feature/sbachmei/MIC-4756-hardware-request-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -h/--hardware option to psimulate
Description
Changes and notes
There are many ways to implement this -C flag including a simple
comma-separated list as well as boolean strings. I opted to have the
user provide a comma-separated list (e.g.
psimulate --hardware r630,r650xs)which then gets converted for the job template to
-C "r630|r650xs". I figuredmaybe one day we will want to get crazy with logic.
Testing
used
psimulate testto confirm this is working.