Create instance creator operation

[jejung]

No description provided.

[daltones]

How about Returns a function that returns a new instance of a predefined class, passing its parameters to the constructor.? I guess it's more precise.

[jejung]

Sure, I will fix it

[daltones]

Same here.

[ihor]

NSPL is focused on speed (which allows us to use this tool in our daily to day projects). There are two optimizations which could be made:

1. Starting PHP 5.6 we have the splat operator .... Using we can get rid of reflection which is relatively slow and have the following code return new $class(...func_get_args());. In my own tests, it makes the speed about two times faster.
2. Again the splat operator is faster than a function call so we can get rid of func_get_args() too. According to my tests, it makes the code about 2.5 times faster than the original version.

So the final code can be something like that:

function instanceCreator($class)
{
    args\expects(args\string, $class);

    return function(...$args) use ($class) {
        return new $class(...$args);
    };
}

We can use PHP_VERSION constant and version_compare function to provide a PHP 5.3 solution too.

[ihor]

Please use camel-cased names $reflectionClass.

[ihor]

I like the idea. Please have a look at my comments and make changes.

One thing I want to ask is to change the branch from master to 1.2. This way I'll be able to release this change in 1.2.1. Current master version contains lazy evaluations which will be released in 1.3.

Also, I would appreciate if you squashed the commits.

Thanks,
Ihor

[jejung]

Thanks for your comments @daltones and @ihor, fixed all of them! Awesome to hear that you can apply this to 1.2.1

[ihor]

Merged and released in 1.2.1. Thanks for the pull request!