New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asterisk (with chan_dongle) and FreePBX #1405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ansible's general recommendation is 2-space indentation.
Okay, some thoughts here...
|
Okay, freepbx 15 seems to install properly with nodejs 10.x. This has a few implications.
|
Checklist:
|
Note: Test only after pulling in #1411 and setting nodejs_version to 10.x |
Brought up to date with master with a forced push. |
Okay. This is now good to test after locally merging #1411 |
Comprehensive test checklist:
|
If this is well-tested & not disruptive to Sugarizer over the coming ~48h, we can consider this for inclusion in IIAB 6.7 |
You can see from the checklist that I made good progress on the testing front, but since the scripts in asterisk and especially freepbx do many things, i would like atleast someone else other than me to also install and test, preferably from scratch, on bare metal. I would be much more confident then. Unfortunately, I dont have access to a NUC over the coming few days. |
Okay, this is now serious enough that I removed the TESTING tag, which reflects the progress that's been made on this. |
Brought up to date with current master. |
@m-anish asks for testing on actual hardware (not just VM's). CLARIF: Ubuntu Server 18.04 is required for now. @jvonau suggesting 2 ways to deal to make pbx.lan work with dnsmasq:
|
Sure, I will add to my todo to edit this PR to edit /etc/hosts |
fyi Node.js 10.x is now part of IIAB (master branch iiab/iiab) if that helps Asterisk/FreePBX move forward: |
Very nice. I think I need to appropriately make changes to this playbook then. |
roles/pbx/tasks/main.yml
Outdated
@@ -7,8 +7,8 @@ | |||
|
|||
- name: Install asterisk | |||
include_tasks: asterisk.yml | |||
when: internet_available and is_ubuntu_18 and pbx_install and (not pbx_installed) and (not sugarizer_install) and (nodejs_version == "10.x") | |||
when: internet_available and ((is_debian and ansible_distribution_major_version == "9") or is_ubuntu_18) and pbx_install and (not pbx_installed) and (nodejs_version == "10.x") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-anish can you make this and Line 14 condition a bit more flexible, so Debian 10 and other Ubuntus (like 19.04 coming in April) and Raspbian-on-RPi might actually work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will once I have tested those platforms. But want to stick to this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure you understood my point:
-
Can you please consider is_ubuntu rather than is_ubuntu_18 ? So we avoid sabotaging diverse Ubuntu volunteers who want to expand on your work over the coming year!
-
Likewise can you please consider
is_debian and (not is_rpi)
instead ofis_debian and ansible_distribution_major_version == "9"
— so that the growing number of Debian 10 people can consider your work? (Without "artificial obstacles" being thrown in their path!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- consider
is_debian and (not is_rpi)
Another option might be is_debian
(just like is_ubuntu
ideally) simplifying in the future anyway!?
@m-anish I'm going to go ahead and merge but I need your help testing/refining:
|
On your host machine, you will need to add an entry to And then open http://pbx.lan/freepbx to test. |
Is this in gateway or appliance? |
Whatever's normal for a VM with a single network interface! Log into it (192.168.0.161) if that's not clear enough? |
VM would be appliance. Please follow the instructions here |
This PR introduces the Asterisk and FreePBX applications for IIAB installs on top of Ubuntu 18.x based setups.
Note: This is for testing only at this point. Do not merge!You will have to atleast set pbx_install to True to have both apps install. And optionally set the enabled flag to enable them as well.
Eagerly looking forwards to test results and polishing this further. We could potentially experiment with running this on debian 9.6 as well.