Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify node-js installation from nodesource and a variable for version #1411

Closed
wants to merge 1 commit into from

Conversation

m-anish
Copy link
Contributor

@m-anish m-anish commented Jan 18, 2019

For 7.0, we should think about simplifying the way nodejs is installed. This PR does that:

  1. Introduces a variable to set nodejs version
  2. Installs from nodesource regardless of platform

@holta holta added this to the 6.7 milestone Jan 18, 2019
@holta
Copy link
Member

holta commented Jan 18, 2019

@jvonau what's the risk of going with #1411 here? (It might even be safer to keep Sugarizer running reliably on Node.js 8.x across all distros...)

@holta
Copy link
Member

holta commented Jan 30, 2019

Clarif: PR #1430 extends this to work with Red Hat-family OS's like CentOS 7 too, i.e. our legacy distros that IIAB has always tried to support informally over the years (but to a lesser degree than Raspbian/Ubuntu/Debian).

@m-anish
Copy link
Contributor Author

m-anish commented Jan 30, 2019

Clarif: PR #1430 extends this to work with Red Hat-family OS's like CentOS 7 too, i.e. our legacy distros that IIAB has always tried to support informally over the years (but to a lesser degree than Raspbian/Ubuntu/Debian).

+1, closing this

@m-anish m-anish closed this Jan 30, 2019
@m-anish m-anish deleted the nodesource branch February 10, 2019 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants