Reserved device [reserved_device LAN-side networking variable]

[jvonau]

untested

[holta]

@jvonau,

Currently https://github.com/iiab/iiab/wiki/IIAB-Networking#common-customizations says:

(2) If your Internet-in-a-Box (IIAB) contains multiple Wi-Fi interfaces, put the following into /etc/iiab/local_vars.yml to ask IIAB not to create a LAN-side access point on the wlan0 interface:

reserved_wifi: wlan0

Is this related and/or should it be changed?

Ref: #2610

[jvonau]

S/B changed see 1693e50 & aed16ca, the description now needs work as this routine never really was wifi specific but that was the original use cases. "used to exclude listed device in network detection and calculation of 'br0's member(slave) devices'"

[holta]

the description now needs work as this routine never really was wifi specific but that was the original use case

Not the final word, but hopefully this documentation/explanation is improved:

https://github.com/iiab/iiab/wiki/IIAB-Networking#common-customizations -> Item (2)

[holta]

@georgejhunt can you review this and/or suggest what testing is most desirable?

[georgejhunt]

This PR deletes initiaization of /etc/iiab/iiab.env for network interfaces. Without extensive testing, I think the risk of unintended consequences is pretty high. Who knows how many times the values in /etc/iiab/iiab.env are used? I don't.

Unrelated note: I remember that the admin console has a reboot and poweroff button which caused my Digital Ocean droplet to fall off line when I thought I had the buttons disabled.

[holta]

This PR deletes [initialization] of /etc/iiab/iiab.env for network interfaces

Is that confirmed true?

Or is it possible this recording to iiab.env is just moved down from Line 7 (detected_network.yml) to Line 53 (enable_services.yml) of...?

https://github.com/iiab/iiab/blob/master/roles/network/tasks/main.yml

[georgejhunt]

Sorry, I missed that move to a different file.

[holta]

I remember that the admin console has a reboot and poweroff button which caused my Digital Ocean droplet to fall off line when I thought I had the buttons disabled.

@tim-moody do you understand that?

[georgejhunt]

I'm sorry Tim that Adam had to bother you about trying to figure out what I meant.
The variable I was too lazy to find was:
./roles/js-menu/files/menu.json:16:  "allow_poweroff" : true
I was not taking responsibility for my error and not remembering correctly.

[holta]

@tim-moody do you have time to review this PR or suggest what testing is most desirable?