Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch Maps7.3 -- includes 2020 OSM data and 2020 satellite images #3165

Merged
merged 5 commits into from
Apr 21, 2022

Conversation

georgejhunt
Copy link
Contributor

Tested on Ubuntu vbox, and rpi hardware, San_Jose, Spanish_speakers, Central_America, and tested on my repo. Needs to be coordinated with branch maps7.3 into the iiab/maps rep. This is a test version and cannot be pulled into master without modification to roles/osm-vector-maps/defaults/main.yml.

Code for generation is a jupyter notebook at https://github.com/georgejhunt/maps/blob/maps7.3/osm-source/jupyter-code/maps.ipynb.

Notes: For 2020 (this version) are at https://github.com/georgejhunt/maps/blob/maps7.3/osm-source/jupyter-code/README.md

@holta holta added this to the 8.0 milestone Apr 5, 2022
@holta
Copy link
Member

holta commented Apr 5, 2022

Looks great! If anybody's reviewing this, see also its partner PR here:

And this point form (8 bullets) summary:

@jvonau
Copy link
Contributor

jvonau commented Apr 5, 2022

Not that upgrades are supported given admin-console would need to be reinstalled also.. Is there any harm other than taking up space in having the older 2019 files laying around the filesystem? I pulled this PR and just did a sudo ./runrole --reinstall osm-vector-maps on an install that never installed additional regions via the admin-console, what needed to be updated was marked 'changed'.

@tim-moody
Copy link
Contributor

So no backwards compatibility? Once you install iiab that's the osm version you get. Same for adm cons. If you try to reinstall with a new version it may or may not work.

@holta
Copy link
Member

holta commented Apr 9, 2022

@holta
Copy link
Member

holta commented Apr 15, 2022

@georgejhunt a side question:

Is it possible...these 2 can be deleted?

Or is that last one useful?

@holta
Copy link
Member

holta commented Apr 19, 2022

@georgejhunt what remaining testing is needed if any — prior to merging this PR?

Related Admin Console PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants