Pbx lock

[jvonau]

Fixes bug:

#3489 (comment)
#3489 (comment)

Smoke-tested on which OS or OS's:

Ubuntu VM for the lockout
RasPiOS64-bit for the patching

Mention a team member @username e.g. to help with code review:

[jvonau]

TASK [pbx : Open-or-Close Asterix ports (including Apache port 83) in iptables firewall, depending on pbx_enabled [True] in local_vars.yml - in support of './runrole pbx'] ***
fatal: [127.0.0.1]: FAILED! => {"changed": false, "cmd": "/usr/bin/iiab-gen-iptables", "msg": "[Errno 2] No such file or directory: b'/usr/bin/iiab-gen-iptables'", "rc": 2, "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
ignoring

This one should have a 'when: iiab_stage|int == 9' to drop the needless warning when selected before installation

http://sprunge.us/Gou2eM installed with iiab 3522

[holta]

The Asterisk/FreePBX community generally does not stop the Asterisk service before installing FreePBX

So I'm not on board with deviating from their mainline community install practices.

[holta]

Not that their guidelines are spelled out clearly.

But sticking with their mainline community practice consensus (as much as possible) is important.

[jvonau]

Be a leader not a follower.

[jvonau]

Clean install tested at 32c81bb http://sprunge.us/GtZntD
last 2 commits 4da7a3f tested with runrole http://sprunge.us/Zwkrnk

[jvonau]

On side note should really record the values of pbx_use_apache, pbx_use_nginx and record the installation of apache in iiab_state.

[jvonau]

Going to clean test this as is at 094d66e back in a couple of hours

http://sprunge.us/4Pa4XL for this commit.

[jvonau]

Apologies I'm not on board here.
The original enable-or-disable.yml is more complete (disabling things more thoroughly, as it should).

Please point out how that is 'more thoroughly'

[jvonau]

Big Red Warnings

[jvonau]

Side issue

Determined Asterisk version to be: 20.2.0
No directory /var/www/html/freepbx/admin/modules/framework/amp_conf/htdocs, install script not needed
Generating CSS...Done
Module framework version 16.0.39 successfully installed
Updating Hooks...Done
Chowning directories...Done
Setting Permissions...
Setting base permissions...Done in 1 seconds
Setting specific permissions...
 2526 [============================]
Finished setting permissions
changed: [127.0.0.1] => (item=./install -n --webroot /var/www/html/freepbx --dbuser asterisk --dbpass asterisk)

ls /var/www/html/freepbx/admin/modules/framework/
hooks  install.php  LICENSE  module.sig  module.xml  phpunit.xml  README.md  utests

Looks to be a change in the installer and not really an error see 'No directory' above

[holta]

Please point out how that is 'more thoroughly'

Whether Ansible or NGINX are perturbed or not, no matter if by cosmic rays or operator error or any other reason, the original when: clauses in enable-or-disable.yml follow the intentions expressed by {pbx_enabled, pbx_use_apache, pbx_use_nginx} within local_vars.yml, which is what's needed.

[jvonau]

Now with the moving of apache.yml to main.yml we could make the default for pbx_use_apache to be False and could be installed on demand at any point in the future without rerunning the entire role.

[jvonau]

same machine as 4Pa4XL with a git pull, toggling pbx_use_apache to be True and runrole applied http://sprunge.us/Vgk14R

[jvonau]

Mirror of the official Asterisk (https://www.asterisk.org/) Project repository. No pull requests here please. Use Gerrit:
[gerrit.asterisk.org](https://gerrit.asterisk.org/)

@holta you can take the lead getting the patch merged upstream now.