New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXPERIMENTAL: 'asterisk_rpi_patch: True' option for Raspberry Pi + preliminary path to FreePBX on PHP 8 #3523
Conversation
hunk was failing not sure why but aptitude did the right thing anyway
Co-authored-by: A Holt <holta@users.noreply.github.com>
pbx_use_apache is an install time option once installed the service needs to be accounted for
Tested successfully on Debian 11 (x86_64). @EMG70 you might want to test this on a fresh 64-bit Raspberry Pi OS? If so, run:
➡️ 2023-04-03 REVISION: Variable is now renamed to AND THEN (when it asks you to edit /etc/iiab/local_vars.yml) look near the very bottom of the file, which is where you'd want to uncomment this line:
WHICH MEANS... changing it to:
AND OF COURSE... set these 2 lines too:
(Finally then run |
Question, in the above screenshot is port 83 being used for apache or are you using nginx directly? |
Ref: #2954 The apache option is more of a debugging option held over from the initial porting to nginx to check if an issue might be related to the use of nginx or a problem with asterisk/freepbx. I would rather set the default for apache to be not installed. The current code could install apache on demand at any point in the future if needed as the whole role does not need to be repeated now. Would you be comfortable enough to initially only use nginx? |
The second picture has 'Asterisk' with some symbol other than a check mark like the first picture has. |
I will try again this evening ,it normally disappears after refreshing. I forgot to do that. |
Noted.Thanks. |
Might want to note that pbx_use_apache can be changed post-install with a pass through runrole or iiab-configure to activate the change. Other than that "push it" for greater feedback. |
@@ -7,7 +7,7 @@ | |||
+ arch=$(uname -m) | |||
if [ ${#pkgs} -ne 0 ]; then | |||
- echo $pkgs | sed -r -e "s/ ?[^ :]+:i386//g" | |||
+ if [ "$arch" = "X86_64" ]; then | |||
+ if [ "$arch" = "x86_64" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I must of been out of coffee. :)
This PR can't please everyone but brings options to Raspberry Pi, cleans up a lot of documentation, and is more than good enough! Thanks to everyone and especially to @EMG70 who put in several full days of testing. NOTE that Apache is being gradually phased out, and should be reduced in prominence, so will be installed on request only going forward, still by pbx/tasks/freepbx.yml during initial install of IIAB App roles/pbx. (I prefer not to raise the prominence of Apache from pbx/tasks/freepbx.yml to pbx/tasks/main.yml at this point, as it's going away entirely, or so we hope.) Finally, FYI that {SMALL, MEDIUM, LARGE} local_vars.yml files will show these new defaults, during IIAB install:
|
What happens when: |
@tim-moody That was the default for the last while you get both active nginx on port 80 as usual and apache on port 83 |
Just pull apache out now and don't look back as this is the last hold out to nginx only #2762 |
Think I have to clarify, with my version there was no need for any use of 'ignore' error skips as all the code paths were covered with apache.yml in main.yml. Now with the move to main.yml being dropped twiddling pbx_use_apache to True post-install will result in the red warning messages popping up when running through the code as apache is moved back to being an install time only option and the service isn't installed and can't be started with 'ignore' being a crutch to get through the role without puking. |
That's a legit suggestion for the future. Let's revisit that when FreePBX 17 is released with PHP 8 support (pray!!!) |
Running both web servers is a well-documented option, since 2021: https://github.com/iiab/iiab/tree/master/roles/pbx#install-it ( Above was just re-worded ~2 hours ago, trying to de-emphasize this silly-but-still-if-absolutely-necessary option of running both web servers 😄 ) |
If this issue is fixed upstream pull the patching routine out. |
Building on and reworking some aspects of @jvonau's:
Related: