Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show extended run-"index" from Platform.meta.tabulate() #37

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

danielhuppmann
Copy link
Member

Per review comment by @meksor at #33 (comment), this PR has an alternative implementation to show the model-scenario-version "index" of the meta dataframe.

The joining of columns is now done on the database layer using a new argument join_run_index, following the logic that the model-scenario[-version] columns are called "index" in pyam. [Alternative suggestions for the argument-name welcome.]

The argument is optional on the backend, defaulting to show only the run-id. But when calling the meta-dataframe from the facade, the extended "index" is returned.

@danielhuppmann danielhuppmann marked this pull request as ready for review January 4, 2024 15:16
Copy link
Contributor

@meksor meksor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielhuppmann danielhuppmann merged commit 273149c into iiasa:main Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants