Fix Run Meta Query Building #69
Conversation
There was a problem hiding this comment.
Thanks @meksor for digging through the code to fix this issue!
| @@ -176,17 +174,3 @@ def unset_as_default_version(self, id: int) -> None: | |||
|
|
|||
| run.is_default = False | |||
| self.session.commit() | |||
|
|
|||
|
|
|||
| def select_joined_run_index(repository, **kwargs) -> db.sql.Select: | |||
There was a problem hiding this comment.
For what it's worth, I added this function here so that I could use it later to streamline the following almost-duplicate code parts:
Line 94 in 3f45bba
There was a problem hiding this comment.
Yeah i think id take a look at this again in some sort of selection overhaul PR. The problem is that depending on what table is selected the joins have to be different (and there was a bug in the code applying filters twice) so i would try to find some new abstraction for this and the filters to make it less error prone in the future.
There was a problem hiding this comment.
I also had to rename the columns selected ("model"->"model_name") because postgres 15 does not like columns in the result set with the same name as a table from the query
Fixes query building for run meta entry queries. Also adds CI tests for postgres 15 and 16.
Throws a 400 when wrong parameters are used on the meta endpoint.
I also added a compatibility matrix to README.md.
Fixes #55.
(Maybe) implements PR#66?