Fix API deletes #70
Merged
Fix API deletes #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glatterf42
approved these changes
Mar 19, 2024
Because otherwise they are served at a location without a trailing slash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on the production setup deletes fail because no trailing slash is added in the api layer and there is some mishap in how that request is redirected...
I've fixed the api layer and set
redirect_slashes=Falsefor fastapi. All requests to endpoints without trailing slashed will thus result in a404.The docs are now also served with trailing slashes so i can use an nginx rewrite instead of the fastapi redirect.
Should fix #57