Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow run filter #74

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Fix slow run filter #74

merged 5 commits into from
Mar 26, 2024

Conversation

meksor
Copy link
Contributor

@meksor meksor commented Mar 20, 2024

The performance improvement from PR#56 didnt make it into the run filter.
This PR intends to fix that and fix some behaviour of the iamc filter as well..

@meksor meksor changed the title Bugfix/slow run filter Fix slow run filter Mar 20, 2024
Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in principle, just one comment.

ixmp4/data/db/run/filter.py Show resolved Hide resolved
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @meksor!

@meksor meksor merged commit 2ca8994 into main Mar 26, 2024
7 checks passed
@meksor meksor deleted the bugfix/slow-run-filter branch March 26, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants