-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asyncronous Client #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you still add a test for the new functions, maybe especially if the new error is raised correctly?
Other than that, looks good to me :)
I can't really add tests for that, no. There is in general 2 ways the new exception is triggered and they are both dependant on the webserver configuration and how beefy the setup is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, lgtm then :)
Makes some of the client code asynchronous. This enables the concurrent sending of requests for enumerations.
Asynchronicity is /not/ exposed to the user via async functions.
Adds some settings variables to control client behaviour, like retries, how long to wait before retrying and when the new
ApiEncumbered
exception is thrown.Uses
asyncio.Semaphore
to control the maximum concurrency.