Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer log output on RestAPI connection #85

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Nicer log output on RestAPI connection #85

merged 3 commits into from
Apr 30, 2024

Conversation

danielhuppmann
Copy link
Member

A little beautification of the log when connecting to a Platform via the RestAPI.

New output

  • the name of the platform
  • a warning if the server and client versions are not in line
  • the platform notice (if available)

The dsn is now only shown in debug mode.

@danielhuppmann danielhuppmann self-assigned this Apr 22, 2024
@danielhuppmann danielhuppmann marked this pull request as ready for review April 22, 2024 11:46
glatterf42
glatterf42 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't often work with the server, so I'm not sure my opinion matters that much here.

meksor
meksor approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@meksor meksor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielhuppmann danielhuppmann merged commit e33215a into iiasa:main Apr 30, 2024
9 checks passed
@danielhuppmann danielhuppmann deleted the log/api-connection branch April 30, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glatterf42 glatterf42 glatterf42 approved these changes

@meksor meksor meksor approved these changes

Assignees

@danielhuppmann danielhuppmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielhuppmann @meksor @glatterf42