-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous improvements for 2024-W10 #156
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
+ Coverage 75.4% 75.6% +0.1%
=======================================
Files 93 93
Lines 6211 6372 +161
=======================================
+ Hits 4684 4818 +134
- Misses 1527 1554 +27
|
9ff193d
to
4f6d6ed
Compare
Warn of deprecation of eval_anno().
Handle both the review-phase and release data structures.
Improves performance with pandas >= 2.2.0.
- Handle logging in a separate thread for better performance. - Log to a file in the platformdirs.user_log_path() with a time stamp; this also captures show_versions() output. - Use distinct levels for file and console logging. - Absorb adjustments of third-party package logging from former pytest_sessionstart hook. - Avoid creating a log file on trivial or testing CLI invocations.
- Document "no_message_data" config setting. - Use :program: Sphinx role throughout. - Don't use a private command as an example in --help. - Refresh --help output text shown in docs.
- Move CliRunner to .util.click - Add method="click" / "subprocess" switch. - Add .invoke_subprocess() to use subprocess.run() for stronger isolation of command. - Separate temporary_command() to a stand-alone function. - Remove .add_command(). - Simplify mix_models_cli fixture usage. - Move cli_test_group to .cli with command(s) to be use in subprocess.
- Reduce QueueHandler to a typing stub. - Use a function rather than logging.config.dictConfig(). - Set root logger level to DEBUG.
- Filters and levels on e.g. "message_ix_models" logger are not effective when handlers are attached at the root.; cf. https://stackoverflow.com/a/17276457 - Warn and adjust usage where names= is list of str.
Also, don't instantiate the test platform automatically; improves start-up speed.
Python, then package, then extra-deps.
@glatterf42 FYI I ran into some dependency trouble here:
This is the same root cause we ran into with iiasa/ixmp#522. Here I (think I have) resolved it by capping the dask version in upstream.extra-deps in the workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
.util.nodes_ex_world()
for use as a reporting (genno) operator..util.sdmx.eval_anno()
; remove internal usage of this deprecated method.mix-models last-log
CLI command to retrieve the location of the latest log file.Housekeeping/CI:
How to review
Read the diff and note that the CI checks all pass.
PR checklist