-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix flag handling for unlocked and locked #36
Conversation
voltage and phase were converted with the voltage scale factor but the phase is in radian times 10000. To convert to degree is needs to be *180*0.0001/pi
add pi import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cl0-de,
Thanks for the pull request!
Would you mind double-checking issue #35 if I remember correctly, the fix for STAT word is required for all flags?
…e number after shift is as provided in c37.118 standard table 6
I updated all shift operations, changed the "shift operation style" and added a fix in the rocof interpretation a divide by 100 was missing |
Hey @cl0-de, Thanks for the update! I think we got most of the bugs resolved by the community, I will go through the open issues and see if there is any outstanding job to be done before creating a new release branch. |
I updated the merge request to now merge into bugfix-v1.0.1 |
Hey @sstevan, did you need anything more from my site, to close this pull request? |
Hey @windrad6, Have not checked if we need the import line mentioned above:
If not just remove it and we can merge. Thanks! |
The import line is removed. |
This fixes the issue:
Received unknown message from PMU #35