Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flag handling for unlocked and locked #36

Merged
merged 6 commits into from
Apr 11, 2023

Conversation

windrad6
Copy link

This fixes the issue:
Received unknown message from PMU #35

voltage and phase were converted with the voltage scale factor but the phase is in radian times 10000. To convert to degree is needs to be *180*0.0001/pi
Copy link
Contributor

@sstevan sstevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cl0-de,

Thanks for the pull request!
Would you mind double-checking issue #35 if I remember correctly, the fix for STAT word is required for all flags?

@windrad6
Copy link
Author

I updated all shift operations, changed the "shift operation style" and added a fix in the rocof interpretation a divide by 100 was missing

@windrad6 windrad6 requested a review from sstevan April 23, 2022 14:53
@sstevan
Copy link
Contributor

sstevan commented May 1, 2022

Hey @cl0-de,

Thanks for the update!
I was wondering if you could send the same pull request to the bugfix-v1.0.1 branch?

I think we got most of the bugs resolved by the community, I will go through the open issues and see if there is any outstanding job to be done before creating a new release branch.

@windrad6 windrad6 changed the base branch from master to bugfix-v1.0.1 May 31, 2022 19:07
@windrad6
Copy link
Author

I updated the merge request to now merge into bugfix-v1.0.1

@windrad6
Copy link
Author

windrad6 commented Dec 2, 2022

Hey @sstevan,

did you need anything more from my site, to close this pull request?

@sstevan
Copy link
Contributor

sstevan commented Dec 3, 2022

Hey @windrad6,

Have not checked if we need the import line mentioned above:

from curses import def_prog_mode

If not just remove it and we can merge. Thanks!

@windrad6
Copy link
Author

The import line is removed.

@sstevan sstevan merged commit e9681ca into iicsys:bugfix-v1.0.1 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants