Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoList helper #166

Merged
merged 12 commits into from
Jun 1, 2023
Merged

AutoList helper #166

merged 12 commits into from
Jun 1, 2023

Conversation

digitaldogsbody
Copy link
Member

@digitaldogsbody digitaldogsbody commented Feb 17, 2023

This is a proof-of-concept for #121

It still needs to be updated for all the properties that must be lists

Closes #121

@digitaldogsbody
Copy link
Member Author

Agreed to merge once list of affected properties is updated

@digitaldogsbody
Copy link
Member Author

This should now be ready for merge, but there's a few things to unpack here (and I had to get into the weeds of both Pydantic and Rob's clever property assignment stuff), so I'd like to go over it on the call.

Also a reminder to myself that I need to open a ticket about the __root__ item on Resource which is being weird (hooray).

@digitaldogsbody digitaldogsbody changed the title AutoList POC AutoList helper Mar 10, 2023
@digitaldogsbody digitaldogsbody marked this pull request as draft March 10, 2023 14:41
@digitaldogsbody digitaldogsbody marked this pull request as ready for review June 1, 2023 15:10
@digitaldogsbody digitaldogsbody merged commit c91fa7a into main Jun 1, 2023
@digitaldogsbody digitaldogsbody deleted the auto_list branch June 1, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-conversion of str to list when appropriate
1 participant