Setting up tests and linting in tox #32

helrond · 2022-03-21T13:47:25Z

Adds tox config to run tests and linting using flake8. Updates Github Actions config file.

Still to come:

Run linting against current codebase (probably makes sense to merge as many PRs as possible first)
Address use of coveralls/coverage
Solidify flake8 configs

Makes changes to the test files in order to fix linting issues.

Fixes iiif_prezi3/ base and loader files to pass linting checks

Fixes linting errors for the general setup.py file. Changes isorts and removes whitespace around parameters.

Fixes the linting in the helper collection_add_methods

Fixes linting for canvas_sizes helper

Makes changes to auto_fields in helpers to pass linting.

Fixes the import order in the helpers init file.

Ignores certain error messages by line in init files due to the way we've imported modules.

helrond added 3 commits March 20, 2022 11:26

add tox and flake8 configs

b22c1d0

adding info on tests to readme

e2ca1e1

updating gh actions

7b1ea02

helrond marked this pull request as draft March 21, 2022 13:47

helrond and others added 16 commits March 21, 2022 09:52

install tox

2d10ac1

using tox-gh-actions

0e6ed0a

Merge branch 'main' into issue-28

43293e3

fix tests

24f5968

ignore missing docstrings

c6188bd

linting config

12f1bcc

linting extensions

7d45e5e

Fix linting in tests

b7d518e

Makes changes to the test files in order to fix linting issues.

Merge branch 'issue-28' of https://github.com/RockefellerArchiveCente…

ed7ef14

…r/iiif-prezi3 into issue-28

Fix linting base and loader

75b3ac1

Fixes iiif_prezi3/ base and loader files to pass linting checks

Fix setup linting

6ab817d

Fixes linting errors for the general setup.py file. Changes isorts and removes whitespace around parameters.

linting collection_add_methods

74d33b1

Fixes the linting in the helper collection_add_methods

Fix linting canvas size

808381e

Fixes linting for canvas_sizes helper

fix auto fields linting

0a47522

Makes changes to auto_fields in helpers to pass linting.

Fixes isort helpers init

3d3a666

Fixes the import order in the helpers init file.

ignore F401 and F403 in init

e294932

Ignores certain error messages by line in init files due to the way we've imported modules.

helrond marked this pull request as ready for review April 25, 2022 17:28

glenrobson merged commit 48bd0a8 into iiif-prezi:main May 6, 2022

Provide feedback