Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json argument fix #96

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Json argument fix #96

merged 2 commits into from
Nov 11, 2022

Conversation

digitaldogsbody
Copy link
Member

Updates the way we handle arguments in the .jsonld() function (and therefore in the .json() wrapper) and adds by_alias=True to the enforced arguments to Pydantic

Closes #95

@digitaldogsbody digitaldogsbody mentioned this pull request Nov 11, 2022
Merged
@digitaldogsbody digitaldogsbody merged commit fa98eb5 into main Nov 11, 2022
@digitaldogsbody digitaldogsbody deleted the json_argument_fix branch November 11, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacomomarchioro giacomomarchioro giacomomarchioro approved these changes

@glenrobson glenrobson glenrobson approved these changes

@helrond helrond Awaiting requested review from helrond

@p-galligan p-galligan Awaiting requested review from p-galligan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.json and .jsonld functions can pass invalid keywords to the underlying functions
3 participants
@digitaldogsbody @glenrobson @giacomomarchioro