Close support subtitle visibility, #4235

This commit will:
- Add a Hide Subtitles/Show Subtitles item to the Subtitles menu
- Add a Hide Second Subtitles/Show Second Subtitles item to the
  Subtitles menu
- Add a key binding mapping v to cycle sub-visibility
- Add a key binding mapping Alt-v to cycle secondary-sub-visibility
- Add a new OSD messages Subtitles Hidden/Visible
- Add a new OSD messages Second Subtitles Hidden/Visible
- Add secondary-sub-visibility to watch-later-options
- Add logging of watch-later-options

These changes add a graphical user interface for the mpv features that
control subtitle visibility.

iina/Base.lproj/Localizable.strings

@@ -54,8 +54,10 @@
 "osd.sub_delay.later" = "Subtitle Delay: %.2fs Later";
 "osd.sub_delay.earlier" = "Subtitle Delay: %.2fs Earlier";
 "osd.subtitle_pos" = "Subtitle Position: %.1f";
-"osd.sub_visibility" = "Subtitle Visibility: %@";
-"osd.sub_second_visibility" = "Second Subtitle Visibility: %@";
+"osd.sub_hidden" = "Subtitles Hidden";
+"osd.sub_visible" = "Subtitles Visible";
+"osd.sub_second_hidden" = "Second Subtitles Hidden";
+"osd.sub_second_visible" = "Second Subtitles Visible";
 "osd.mute" = "Mute";
 "osd.unmute" = "Unmute";
 "osd.screenshot" = "Screenshot Captured";

iina/MPVController.swift

@@ -1134,15 +1134,15 @@ class MPVController: NSObject {
       if let visible = UnsafePointer<Bool>(OpaquePointer(property.data))?.pointee {
         if player.info.isSubVisible != visible {
           player.info.isSubVisible = visible
-          player.sendOSD(.subVisible(visible))
+          player.sendOSD(visible ? .subVisible : .subHidden)
         }
       }
 
     case MPVOption.Subtitles.secondarySubVisibility:
       if let visible = UnsafePointer<Bool>(OpaquePointer(property.data))?.pointee {
         if player.info.isSecondSubVisible != visible {
           player.info.isSecondSubVisible = visible
-          player.sendOSD(.secondSubVisible(visible))
+          player.sendOSD(visible ? .secondSubVisible : .secondSubHidden)
         }
       }
 

iina/OSDMessage.swift

@@ -44,8 +44,10 @@ enum OSDMessage {
   case audioDelay(Double)
   case subDelay(Double)
   case subScale(Double)
-  case subVisible(Bool)
-  case secondSubVisible(Bool)
+  case subHidden
+  case subVisible
+  case secondSubHidden
+  case secondSubVisible
   case subPos(Double)
   case mute
   case unMute
@@ -174,17 +176,17 @@ enum OSDMessage {
         .withProgress(value / 100)
       )
 
-    case .subVisible(let enabled):
-      return (
-        String(format: NSLocalizedString("osd.sub_visibility", comment: "Subtitle Visibility: %@"), enabled ? NSLocalizedString("general.on", comment: "On") : NSLocalizedString("general.off", comment: "Off")),
-        .normal
-      )
+    case .subHidden:
+      return (NSLocalizedString("osd.sub_hidden", comment: "Subtitles Hidden"), .normal)
 
-    case .secondSubVisible(let enabled):
-      return (
-        String(format: NSLocalizedString("osd.sub_second_visibility", comment: "Second Subtitle Visibility: %@"), enabled ? NSLocalizedString("general.on", comment: "On") : NSLocalizedString("general.off", comment: "Off")),
-        .normal
-      )
+    case .subVisible:
+      return (NSLocalizedString("osd.sub_visible", comment: "Subtitles Visible"), .normal)
+
+    case .secondSubHidden:
+      return (NSLocalizedString("osd.sub_second_hidden", comment: "Second Subtitles Hidden"), .normal)
+
+    case .secondSubVisible:
+      return (NSLocalizedString("osd.sub_second_visible", comment: "Second Subtitles Visible"), .normal)
 
     case .mute:
       return (NSLocalizedString("osd.mute", comment: "Mute"), .normal)

iina/en.lproj/Localizable.strings

@@ -54,8 +54,10 @@
 "osd.sub_delay.later" = "Subtitle Delay: %.2fs Later";
 "osd.sub_delay.earlier" = "Subtitle Delay: %.2fs Earlier";
 "osd.subtitle_pos" = "Subtitle Position: %.1f";
-"osd.sub_visibility" = "Subtitle Visibility: %@";
-"osd.sub_second_visibility" = "Second Subtitle Visibility: %@";
+"osd.sub_hidden" = "Subtitles Hidden";
+"osd.sub_visible" = "Subtitles Visible";
+"osd.sub_second_hidden" = "Second Subtitles Hidden";
+"osd.sub_second_visible" = "Second Subtitles Visible";"osd.mute" = "Mute";
 "osd.mute" = "Mute";
 "osd.unmute" = "Unmute";
 "osd.screenshot" = "Screenshot Captured";