Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw on duplicate keys in media type parameters #40

Closed
ato opened this issue May 28, 2020 · 0 comments
Closed

Don't throw on duplicate keys in media type parameters #40

ato opened this issue May 28, 2020 · 0 comments
Labels
bug

Comments

@ato
Copy link
Member

ato commented May 28, 2020 •
edited
Loading

Currently we throw IllegalArgumentException but that's not helpful. It looks like the behaviour in browsers varies but there's some momentum towards standardising on the first value and any subsequent ignored: whatwg/mimesniff#41

See also #39.
@ato ato added the bug label May 28, 2020
@ato ato closed this as completed in 3c95c27 May 28, 2020
ato added a commit that referenced this issue May 28, 2020
@ato
Release 0.12.0
b22e267 
New features

* Added contains(name, value) to MessageHeaders for look for values in comma-list headers

Bugs fixed

* Eliminated IllegalArgumentException on duplicate media type parameters #40
* Eliminated usages of sole() when accessing HTTP headers to reduce unnecessary exceptions
* Allow optional space after chunk-size in chunked transfer-encoding #33 (Sebastian Nagel)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ato