Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issues with the POM #3

Closed
anjackson opened this issue Nov 8, 2013 · 8 comments
Closed

Minor issues with the POM #3

anjackson opened this issue Nov 8, 2013 · 8 comments

Comments

@anjackson
Copy link
Member

There is no organization tag.

I wonder if we should explicitly declare this a Maven 3 project? It already conforms to M3.

The compiler plugin specifies Java 6. Seems like a good time to bump this up to 7.

I notice that there is an assembly plugin defined to create a "jar-with-dependencies". This doesn't seem necessary or useful for a library.

@johnerikhalse
Copy link
Contributor

I did a search for public static void main and found that there are 16 classes which are runnable. Some of them are just for testing, but others are meant as tools. If people actually are using it as a command line tool, then it makes sense to keep the jar-with-dependencies.

A better approach would be to separate command line stuff in its own module and keep webarchive-commons as a plain library.

@kris-sigur
Copy link
Member

@johnerikhalse
Copy link
Contributor

If we require Java 7, it might also be the right time to remove the classes pulled in from OpenJDK 7 as described in this comment #20 (comment) by @gojomo.

As far as I know, all implementations of Java 7 are using the class library from OpenJDK 7, so this should be safe.

@kris-sigur
Copy link
Member

If we move to Java7 that will affect Wayback and Heritrix as well.

@johnerikhalse
Copy link
Contributor

Since Java 6 reached its end of public updates in February 2013 it seems like a good idea to require Java 7, but that need to be agreed on with the wider community. Any ideas how to proceed?

@johnerikhalse
Copy link
Contributor

To sum this up:

  1. Missing organization tag was added by @anjackson in November 2013
  2. Declare Maven 3 as a prerequisite should not be a very controversial thing to do (proposed version 1.1.5)
  3. Require Java 7 has implications for other projects like Heritrix and OpenWayback. Should probably be an issue of its own (proposed version 1.2.0)
  4. Remove the "jar-with-dependencies" artifact. If we'd like to support the command line use we should make a separate module depending on this one. Should be a separate issue (proposed version 1.2.0)

@johnerikhalse
Copy link
Contributor

I created issue #28 and #29 for the tasks that influence usage of the library.
Created pull request #30 for requiring Maven 3 which is the remaining part of this issue.

@anjackson anjackson modified the milestones: 1.1.6 Release, 1.1.5 Release May 7, 2015
RogerMathisen added a commit that referenced this issue Jul 9, 2015
Issue #3 Require the oldest recommended version of Maven 3
@RogerMathisen
Copy link
Contributor

Seems all requests in this issue either are fixed or moved to new issues under the 1.2.0 release, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants