Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let end-developers set up embroider-css-modules in their Embroider app #135

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Let end-developers set up embroider-css-modules in their Embroider app #135

merged 5 commits into from
Mar 13, 2024

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Mar 13, 2024 •
edited
Loading

Why?

I removed some code that had been introduced in #8 and #18. By letting the codemod focus on removing the ember-css-modules syntax, and letting the end-developers on configuring their projects, I think we can keep the maintenance cost low.

@ijlee2 ijlee2 added the breaking Breaking change will result in a new major version label Mar 13, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited
Loading

✅ Deploy Preview for embroider-css-modules ready!

Name Link
🔨 Latest commit 62990cf
🔍 Latest deploy log https://app.netlify.com/sites/embroider-css-modules/deploys/65f164b8d4b913000894e246
😎 Deploy Preview https://deploy-preview-135--embroider-css-modules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ijlee2 ijlee2 marked this pull request as ready for review March 13, 2024 09:12
@ijlee2 ijlee2 merged commit 48a254c into main Mar 13, 2024
50 checks passed
@ijlee2 ijlee2 deleted the separate-concerns branch March 13, 2024 09:20
ijlee2 added a commit that referenced this pull request Mar 14, 2024
@ijlee2
chore: Patched #134 and #135
97f07cd
ijlee2 added a commit that referenced this pull request Mar 14, 2024
@ijlee2
Provided an additional tip for refactoring (#136)
71d0712 
* chore: Patched #134 and #135

* feature: Provided an additional tip for refactoring

---------

Co-authored-by: ijlee2 <ijlee2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Breaking change will result in a new major version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ijlee2